Updating hello-jnicallback to support large screen devices #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggfan
approved these changes
Jan 25, 2023
Timer does not restart on configuration changes and utilizes a ViewModel to preserve state. Button added to start and stop. Small naming convention fix with stopTimer
DanAlbert
force-pushed
the
hello-jnicallback-largeScreenUpdate
branch
from
fbc5ebc to
6110460
Compare
|
Sorry for the delay, there wasn't anyone to look after the samples for a while. What does this actually fix? What's a "large screen device"? I don't know how to verify that this does what it says. |
|
I can see that one thing it does fix is that the timer doesn't restart when the screen rotates, but I'm still not sure what this has to do with "large screen devices", whatever those are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timer does not restart on configuration changes and utilizes a ViewModel to preserve state. Timer functionality refactored into this ViewModel.
Button added to start and stop.
Changed StopTimer to stopTimer to match naming convention.