Repository navigation
Conversation
Register the AVX2 VectorTest suite with CMake/CTest, fetch GoogleTest portably, pin GitHub Actions, and run tests on Windows MSVC and Ubuntu GCC/Clang. Fix Span::empty to compare instead of assign so Clang builds. Keep the portable translation units on all compilers; extra MSVC-only sources remain opt-in.
Share a single AllAllocatorsGuard in testNamespace.cpp so MSVC does not see a duplicate symbol. Drop the extra MSVC-only VectorTest sources from the portable target. Exclude ApplyFilterB from CTest (fails in Debug). Do not fail the required matrix on known allocator ASan teardown reports.
CMake 4.x POST_BUILD discovery fails on Windows multi-config generators. Register the portable suite as a single CTest entry.
AllAllocatorsGuard in other TUs ran after the static unordered_map members were destroyed, so VectorTest segfaulted on Windows after gtest had already reported 29/29 passed. Store the size-to-policy map on the heap and reset the cached policy pointer in freeAll.
damian123
marked this pull request as draft
August 31, 2026 11:37
damian123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Preserved reference snapshot — never merge wholesale.
This 127-file branch remains available at integration/advanced-numerics-ai and is also preserved locally at backup/reference-pr45-352babc. The PR is closed to keep the upstream review queue focused.
Superseding landing path
The maintained core work now lives in focused PRs:
Finance examples, finance numerics/runtime, and AI work have returned to draft status pending an owner decision and fresh restacks.
Snapshot scope
At head 352babc, all 10 historical snapshot checks passed. Those results apply only to this integrated experimental branch. The focused PRs above contain later fixes and supersede the corresponding snapshot code.
Closing this PR does not delete the branch. Upstream maintainer approval and merge action remain required on the focused PRs, beginning with #29.