Skip to content

Add keccak256, Secp256k1{Sign, Verify, PubKey} builtins#3417

Merged
janmasrovira merged 12 commits intomainfrom
keccack
May 26, 2025
Merged

Add keccak256, Secp256k1{Sign, Verify, PubKey} builtins#3417
janmasrovira merged 12 commits intomainfrom
keccack

Conversation

@janmasrovira
Copy link
Collaborator

No description provided.

@janmasrovira janmasrovira self-assigned this May 22, 2025
@janmasrovira janmasrovira changed the title Add keccack256, Secp256k1{Sign, Verify, PubKey} builtins Add keccak256, Secp256k1{Sign, Verify, PubKey} builtins May 22, 2025
@janmasrovira janmasrovira marked this pull request as ready for review May 23, 2025 13:17
@janmasrovira janmasrovira requested a review from lukaszcz May 23, 2025 13:17
lukaszcz
lukaszcz previously approved these changes May 23, 2025
Copy link
Contributor

@lukaszcz lukaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We badly need FFI. The amount of builtins keeps growing unmanageably.

mkLambda :: Info -> Binder -> Node -> Node
mkLambda i bi b = NLam (Lambda i bi b)

-- TODO use this in Core/Translation/FromInternal.hs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue for this refactoring?

@janmasrovira janmasrovira merged commit 991fb0c into main May 26, 2025
4 checks passed
@janmasrovira janmasrovira deleted the keccack branch May 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants