refactor(server): simplify router middleware with next()#21720
Open
refactor(server): simplify router middleware with next()#21720
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
…quest processing - Moves error handler registration to the root app instead of each sub-route - Ensures consistent error responses across all API endpoints - Removes unused imports and simplifies route composition
…ver.Default() synchronous Removes unnecessary await calls on Server.Default() throughout the codebase, simplifying the server initialization flow and removing async overhead for faster startup.
Enables running the agent on Bun runtime in addition to Node.js by abstracting server initialization into runtime-specific adapters. The server will automatically use Bun's native APIs when available.
The previous test was measuring heap growth while running inside the shared Instance context, which included unrelated tool runtime state that could obscure the actual abort controller leak signal. Now the fetch operations run in a dedicated Bun worker process, giving a clean baseline for memory measurement that accurately reflects whether abort listeners are being properly cleaned up after timed fetches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the server router middleware to use Hono's
next()function instead of manually invoking routes.Changes
lazy,InstanceRoutes)nextparameter to middleware handlerroutes().fetch(c.req.raw, c.env)calls withnext()This simplifies the middleware by leveraging Hono's built-in middleware flow control.