feat(build): qualify third-party overrides for 0.17 - #2684
Open
wxyucs wants to merge 1 commit into
Open
Conversation
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Assisted-by: Codex:gpt-5
Collaborator
|
/label status/waiting-for-review |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Require linked issue for feature/bug PRs
|
LHT129
reviewed
Aug 14, 2026
LHT129
reviewed
Aug 14, 2026
LHT129
reviewed
Aug 14, 2026
LHT129
reviewed
Aug 14, 2026
LHT129
reviewed
Aug 14, 2026
LHT129
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes. The PR is well-structured and the implementation is solid:
- The
VSAGThirdPartyOverride.cmakemodule is cleanly designed with proper input validation, collision-resistant hash prefix generation, and credential-safe diagnostics. - All 15 third-party dependency files are consistently migrated to use
vsag_resolve_thirdparty_override, with Alibaba Cloud OSS cache URLs properly removed while preserving authoritative upstream URLs andURL_HASHvalues. - The test suite (
thirdparty_override_test.cmake+thirdparty_override_fixture.cmake) provides thorough coverage: pinned/legacy/default precedence, credential-safe output, mismatched pin rejection, hash verification, and collision prefix extension. - Documentation (EN + ZH) is clear and complete with lookup order, naming rules, inventory table, and practical examples.
No blocking issues found.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 0.17 #2684 +/- ##
==========================================
- Coverage 91.94% 91.85% -0.09%
==========================================
Files 320 320
Lines 17848 17848
==========================================
- Hits 16410 16395 -15
- Misses 1438 1453 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validation
make test-cmakecmake --build build-validation-http-0.17 --target fmt cpuinfo roaring --parallel 2make fmtwith clang-format 15git diff --checkBackport of the approach merged in #2679 for the 0.17-owned dependency pins and URL inventory.
Fixes: #2677