-
Notifications
You must be signed in to change notification settings - Fork 47
interceptors #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TomerAberbach
wants to merge
1
commit into
next
Choose a base branch
from
feat/interceptors-prototype
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
interceptors #266
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
anthropic-java-core/src/main/kotlin/com/anthropic/core/http/HttpClientExecute.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // File generated from our OpenAPI spec by Stainless. | ||
|
|
||
| package com.anthropic.core.http | ||
|
|
||
| import com.anthropic.core.RequestOptions | ||
|
|
||
| fun interface HttpClientExecute { | ||
|
|
||
| fun execute( | ||
| httpClient: HttpClient, | ||
| request: HttpRequest, | ||
| requestOptions: RequestOptions, | ||
| ): HttpResponse | ||
| } |
15 changes: 15 additions & 0 deletions
15
anthropic-java-core/src/main/kotlin/com/anthropic/core/http/HttpClientExecuteAsync.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // File generated from our OpenAPI spec by Stainless. | ||
|
|
||
| package com.anthropic.core.http | ||
|
|
||
| import com.anthropic.core.RequestOptions | ||
| import java.util.concurrent.CompletableFuture | ||
|
|
||
| fun interface HttpClientExecuteAsync { | ||
|
|
||
| fun executeAsync( | ||
| httpClient: HttpClient, | ||
| request: HttpRequest, | ||
| requestOptions: RequestOptions, | ||
| ): CompletableFuture<HttpResponse> | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many users are used to chaining interceptors (or middleware) instead of one big call. Given this can also be done conditionally (for perf reasons for ex.), I think it makes for a better API than enforce all the wrapping in a single call.
Ex. https://square.github.io/okhttp/features/interceptors/
but you can also see this generally with python, js, ruby, java server library middlewares
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually looked at the OkHttp API and considered using the same chaining API, but we felt that the chaining API makes it more difficult to understand the order things run. i.e. does
addInterceptor(A).addInterceptor(B)result inA(B(...))orB(A(...)), while if you do the wrapping yourself the order is crystal clear.It's possible we're overthinking this though; in your experience have folks been confused about ordering of these kinds of things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a general understanding about top-to-bottom/left-to-right ordering, like with GRPC or middleware chains for web server frameworks (think Express for JavaScript or Gin for Go) in most programming language ecosystems. I wouldn't worry about this as an issue from my experience working on the Sentry SDKs.