fix(tool runner): don't exit early on pause_turn
#1174
+78
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Varun Chawla <[email protected]>
karpetrosyan
force-pushed
the
properly-handle-pause-turn
branch
from
562b653 to
063083f
Compare
felixfbecker
approved these changes
Feb 11, 2026
Contributor
felixfbecker
left a comment
felixfbecker
left a comment
There was a problem hiding this comment.
how should this interact with the max_iterations param? I think the tool runner accepts two (one for the client-side iteration limit, one for the server-side limit). The server one would in effect only control the "chunking" of getting server tool responses.
This behavior should probably be documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1170
Problem
The tool runner was exiting early when encountering a
pause_turnstop reason, preventing it from continuing the conversation loop.pause_turnmeans the API paused some operation and wants the client to send back the message to continue it, which is why we should send it back instead of just exiting the loop.