fix: handle shell-quote treating # as comment in claude_args#988
Open
yoheidemachi wants to merge 2 commits intoanthropics:mainfrom
Open
fix: handle shell-quote treating # as comment in claude_args#988yoheidemachi wants to merge 2 commits intoanthropics:mainfrom
yoheidemachi wants to merge 2 commits intoanthropics:mainfrom
Conversation
shell-quote's parse() returns {comment: "..."} objects when it encounters
# characters, even inside flag values. The existing filter dropped these
objects, causing the flag to receive a null value and triggering an AJV
schema validation crash.
Convert comment objects back to strings (prepending #) instead of
dropping them, so values like "# Use best practices" are preserved.
Fixes anthropics#980
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shell-quote'sparse()treats#as the start of a shell comment and returns{comment: "..."}objects instead of strings. The existing.filter(arg => typeof arg === 'string')drops these objects, leaving the preceding flag with no value (null). Thisnullpropagates into the SDK config and triggers an AJV schema validation crash.Changes
{comment: "..."}objects back to strings (prepending#) instead of dropping them#in quoted and unquoted flag valuesReproduction (before fix)
Crashes with AJV validation error because
append-system-promptreceivesnull.Closes #980