Av/327 share resources with inheritance

[anushkavidanage]

Pull Request Details

What issue does this PR address

• Sharing resources with ACL inheritance

• Link to associated issue: SOLIDPOD: Sharing resources with inheritance #357

Testing

• Please use Add/Delete Permission from Any Resource button to test this function.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

• Screenshots included in linked issue
• Changes adhere to the team style and coding guideline
• No confidential information
• No duplicated content
• No lint check errors related to your changes (make prep or flutter analyze lib)
• Pre-exisiting lint errors noted: [HERE]
• Tested on at least one device
  • Android Phone
  • Android Emulator
  • Chrome on Android
  • Chrome
  • iOS
  • Linux
  • MacOS
  • Windows
• Added 2 reviewers (or 1 for private repositories then they add another)

Finalising

Once PR discussion is complete and 2 reviewers have approved:

• Merge dev into the branch
• Resolve any conflicts
• Add one line summary into CHANGELOG.md
• Bump appropriate version number in pubspec.yaml
• Push to git repository and review
• Merge PR into dev

[cdawei]

It seems a folder can be shared in the demo app in my test, thanks Anushka.

But I haven't figured out how to check the sharing from the recipient, as clicking the button View all Resources your WebID have access to shows permissions only for key-value.ttl. Is there another way to test this?

[cdawei]

I can see a log entry in the recipient's logs/permissions-log.ttl about the shared directory, and can also find triples in shared/shared-keys.ttl presumably of the corresponding (encrypted) individual key. Thanks Anushka.

[srodriguez142857]

I get the following error when removing a granted permission for a resource directory:

[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: 'package:solidpod/src/solid/api/rest_api.dart': Failed assertion: line 275 pos 12: 'resUrl.endsWith('/')': is not true.
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:67:4)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:49:5)
#2      checkResourceStatus (package:solidpod/src/solid/api/rest_api.dart:275:12)
#3      removeSharedKey (package:solidpod/src/solid/api/revoke_permission_api.dart:151:13)
<asynchronous suspension>
#4      revokePermission (package:solidpod/src/solid/revoke_permission.dart:123:15)
<asynchronous suspension>
#5      buildPermDataTable.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:solidpod/src/widgets/file_permission_data_table.dart:133:31)
<asynchronous suspension>

Additionally, I don't see any updates as Dawei indicated above (#389 (comment)).

[anushkavidanage]

@srodriguez142857 I've pushed some changes to fix the issue you had. Please have another look and let me know if you see any other issues.

[srodriguez142857]

Hi @anushkavidanage.
I did a round of tests. All good. I get the expected behaviour as Dawei described above.
Thanks.

[srodriguez142857]

The functionality is working as expected.