Tony/163 consistent light theme mode

[tonypioneer]

Pull Request Details

What issue does this PR address

• Replaced the solid sun icon for the light mode with the outlined sun icon

Associated Issue

• This PR relates to issue SOLIDUI: use consistent light theme icon #163.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue SOLIDUI: use consistent light theme icon #163
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[jesscmoore]

Hmmn, it still seems like the theme switching is overly complicated and testing in notepad it seems to note respond to system theme switching. Sorry perhaps there was still confusion on how it should work. I've updated how I think it should work in the issue discussion.

[jesscmoore]

Test results: looks good @tonypioneer, like the 2 icons only. thanks for update!

ipad simulator: does not respond to system theme
macos: theme responsive yay!
ipad physical: theme responsive yay!
chrome: theme responsive yay!

[tonypioneer]

Test results: looks good @tonypioneer, like the 2 icons only. thanks for update!

ipad simulator: does not respond to system theme macos: theme responsive yay! ipad physical: theme responsive yay! chrome: theme responsive yay!

Thanks @jesscmoore. I think the simulator might have some minor issues, similar to the version number display issue we saw yesterday.