Customised Settings widget on AppBar (#27)#211
Customised Settings widget on AppBar (#27)#211Amoghhosamane wants to merge 1 commit intoanusii:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR contains changes only to the example Home page (example/lib/home.dart), which converts it from a static information display into an interactive POD data storage demonstration. The changes add form functionality with text input fields for name and comment, along with save/load operations that encrypt and store data to the user's POD.
Changes:
- Transforms Home page from static content to an interactive POD data storage example with form fields
- Implements encrypted data persistence using POD storage APIs
- Adds proper state management with loading indicators and error handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import 'dart:convert'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:solidpod/solidpod.dart'; | ||
| import 'package:solidui/solidui.dart'; |
There was a problem hiding this comment.
Critical discrepancy between PR description and actual changes: The PR description (title and body) states this PR "adds a settingsWidget parameter to SolidScaffold, allowing developers to define their own settings widget" and claims to integrate it into the AppBar, Navigation Rail, and Navigation Drawer. However, the actual changes only modify the example Home page to add a POD data storage form. No changes to SolidScaffold or any core library files are present in this diff. This suggests either:
- The PR description is incorrect and should describe the actual home.dart changes, or
- The wrong files were included in this PR, or
- The settingsWidget implementation is in a different commit not shown in this diff.
Please verify that the correct changes are included in this PR and update the description accordingly.
There was a problem hiding this comment.
No changes to SolidScaffold or any core library files are present in this diff.
Yes, the changes should be applied to SolidScaffold or some other core library files, not the example app.
This change adds a settingsWidget parameter to SolidScaffold, allowing developers to define their own settings widget (e.g., an IconButton) which is then displayed in the AppBar next to the About button. It also integrates this widget into the Navigation Rail (trailing) and the Navigation Drawer.
Associated Issue
Type of change