Merged
Conversation
fixes aome510#663 Can be reverted once it is fixed upstream in rspotify
Contributor
Author
|
Not much experience with rust so I'm not sure if there is a cleaner way to copy all the properties of first_page without doing it explicitly like this.. |
Owner
Normally, you can do let first_page = rspotify::model::Page {
items: first_page.items.into_iter().map(Some).collect(),
..first_page
};However, in this case, it's not possible because the type of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #663
Can be reverted once it is fixed upstream in rspotify