Fixing bug when performing an action on an album#678
Closed
JohnOberhauser wants to merge 1 commit intoaome510:masterfrom
Closed
Fixing bug when performing an action on an album#678JohnOberhauser wants to merge 1 commit intoaome510:masterfrom
JohnOberhauser wants to merge 1 commit intoaome510:masterfrom
Conversation
… types instead of date
JohnOberhauser
force-pushed
the
sort-fix
branch
from
506420a to
6968e13
Compare
Owner
|
I think it's better to sort the albums upon getting data from the API. This avoids having to sort the data each time we process it. Put up a PR |
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug where performing an action on an album can apply that action to the wrong album.
Introduced in my last PR #654
My original PR sorted the UI, but I didn't realize actions on albums happen based on the selected index (not the selected album). So I'm adding album sorting to the album event window as well.