feat: add currently playing lyric highlight#733
Merged
aome510 merged 3 commits intoaome510:masterfrom Jun 22, 2025
Merged
Conversation
|
Hi, I'm a user of this project and I've tested this pull request. It works perfectly for me, no issues so far. Thanks for the feature, very useful. Environment details:
|
Contributor
Author
|
@aome510 Is this something you'd like? |
aome510
approved these changes
Jun 22, 2025
Owner
aome510
left a comment
aome510
left a comment
There was a problem hiding this comment.
Thanks for implementing this feature. LGTM!!!
tojamrok
pushed a commit
to tojamrok/spotify-player
that referenced
this pull request
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it a little confusing the first time I opened the Lyrics panel and the currently playing lyric is dimmed.
I added a highlight for the current playing lyric
Should resolve confusion found in these issues
spotify_lyrics.mp4