feat: remember Tracks context in Currently Playing page#933
Merged
Conversation
Add support for preserving Tracks context (Top Tracks, Recently Played, Liked Tracks) when navigating to the Currently Playing page. Since Spotify's native API only recognizes Playlist, Album, Artist, and Show as playback contexts, custom Tracks contexts were previously lost when viewing the Currently Playing page. This change tracks the currently playing Tracks context in UIState and displays it appropriately. Changes: - Add `currently_playing_tracks_id` field to `UIState` to store the active Tracks context - Modify `ContextPageType::CurrentPlaying` to accept optional `TracksId`, indicating the currently playing Tracks context - Update playback handlers to set/clear `currently_playing_tracks_id`: - Set when playing from Tracks contexts (Top/Recent/Liked Tracks) - Clear when playing from other contexts (Playlist, Album, Show, etc.) This allows users to see and navigate the Tracks context list when viewing the Currently Playing page after playing from these contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for preserving Tracks context (Top Tracks, Recently Played, Liked Tracks) when navigating to the Currently Playing page.
Since Spotify's native API only recognizes Playlist, Album, Artist, and Show as playback contexts, custom Tracks contexts were previously lost when viewing the Currently Playing page. This change tracks the currently playing Tracks context in
UIStateand displays it appropriately.Resolves #825
Changes
currently_playing_tracks_idfield toUIStateto store the active Tracks contextContextPageType::CurrentPlayingto accept optionalTracksId, indicating the currently playing Tracks contextcurrently_playing_tracks_id:This allows users to see and navigate the Tracks context list when viewing the Currently Playing page after playing from these contexts.