Add test coverage for untested VaultBackend path branches#62694
Open
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Open
Add test coverage for untested VaultBackend path branches#62694SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Conversation
Add coverage for connections_path="" to ensure connection IDs are not prefixed. Extend mount_point=None test to cover non-prefixed keys returning None and avoiding Vault calls.
boring-cyborg
bot
added
area:providers
area:secrets
provider:hashicorp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test coverage for previously untested edge cases in
VaultBackendpath resolution.Specifically, this change adds coverage for the
connections_path=""branch to ensure connection IDs are not automatically prefixed, and extends themount_point=Nonescenario to verify that non-prefixed keys correctly returnNonewithout invoking Vault.Rationale
These branches are reachable through documented configuration options but were not explicitly protected by existing tests. Adding coverage ensures correct path resolution semantics are preserved and prevents regressions in shared
_parse_pathlogic affecting connection retrieval behavior.