Skip to content

GH-825: Add UUID canonical extension type #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-825: Add UUID canonical extension type #903

wants to merge 2 commits into from

Conversation

@jhrotko
Copy link

@jhrotko jhrotko commented Nov 3, 2025 •
edited
Loading

What's Changed

Add Uuid Extension type canonical implementation in Java. The proposed implementation was validated in Dremio engine

Closes #825

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Thank you for opening a pull request!

Please label the PR with one or more of:

  • bug-fix
  • chore
  • dependencies
  • documentation
  • enhancement

Also, add the 'breaking-change' label if appropriate.

See CONTRIBUTING.md for details.

lidavidm
lidavidm requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous PR. It is not sufficient to move the existing files, the "uuid" type used in tests was never meant to implement the canonical type. #824

@jhrotko jhrotko changed the title GH-825: Move UuidType to arrow.vector from test GH-825: Implement Uuid canonical type Nov 7, 2025
@jhrotko jhrotko changed the title GH-825: Implement Uuid canonical type GH-825: Add a canonical extension type UUID Nov 7, 2025
@jhrotko jhrotko marked this pull request as ready for review November 7, 2025 13:58
@jhrotko
Copy link
Author

jhrotko commented Nov 7, 2025 •
edited
Loading

@lidavidm could you take another look? Let me know if anything else is missing

@jhrotko jhrotko changed the title GH-825: Add a canonical extension type UUID GH-825: Add UUID canonical extension type Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm requested changes

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce type support for UUID as a canonical extension type

2 participants

@jhrotko @lidavidm