arrow-schema: Remove dict_id from being required equal for merging #7968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6356
Rationale for this change
Now that #7940 is merged, nothing useful can be done with the
dict_idfield, therefore, it is now safe to be removed from this requirement.This was also split out from: #7467
What changes are included in this PR?
No longer require the
dict_idfields of twoFields of schemas being merged to be equal, as at this point thedict_idis only an IPC concern, and the fact that it is still in the struct definition is just legacy, marked for removal, we're just going through the proper procedure of deprecating and replacing the APIs that use it.Are these changes tested?
Tests passing.
Are there any user-facing changes?
No API changes, just a behavior change, that was to be expected and desired due to the deprecations around the
dict_idfield.@alamb @adriangb @tustvold