Skip to content

[Variant] Remove create_test_variant_array helper method #8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

[Variant] Remove create_test_variant_array helper method #8664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions parquet-variant-compute/src/shred_variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,22 +331,11 @@ mod tests {
use parquet_variant::{ObjectBuilder, ReadOnlyMetadataBuilder, Variant, VariantBuilder};
use std::sync::Arc;

fn create_test_variant_array(values: Vec<Option<Variant<'_, '_>>>) -> VariantArray {
let mut builder = VariantArrayBuilder::new(values.len());
for value in values {
match value {
Some(v) => builder.append_variant(v),
None => builder.append_null(),
}
}
builder.build()
}

#[test]
fn test_already_shredded_input_error() {
// Create a VariantArray that already has typed_value_field
// First create a valid VariantArray, then extract its parts to construct a shredded one
let temp_array = create_test_variant_array(vec![Some(Variant::from("test"))]);
let temp_array = VariantArray::from_iter(vec![Some(Variant::from("test"))]);
let metadata = temp_array.metadata_field().clone();
let value = temp_array.value_field().unwrap().clone();
let typed_value = Arc::new(Int64Array::from(vec![42])) as ArrayRef;
Expand Down Expand Up @@ -375,15 +364,15 @@ mod tests {

#[test]
fn test_unsupported_list_schema() {
let input = create_test_variant_array(vec![Some(Variant::from(42))]);
let input = VariantArray::from_iter([Variant::from(42)]);
let list_schema = DataType::List(Arc::new(Field::new("item", DataType::Int64, true)));
shred_variant(&input, &list_schema).expect_err("unsupported");
}

#[test]
fn test_primitive_shredding_comprehensive() {
// Test mixed scenarios in a single array
let input = create_test_variant_array(vec![
let input = VariantArray::from_iter(vec![
Some(Variant::from(42i64)), // successful shred
Some(Variant::from("hello")), // failed shred (string)
Some(Variant::from(100i64)), // successful shred
Expand Down Expand Up @@ -448,10 +437,10 @@ mod tests {

#[test]
fn test_primitive_different_target_types() {
let input = create_test_variant_array(vec![
Some(Variant::from(42i32)),
Some(Variant::from(3.15f64)),
Some(Variant::from("not_a_number")),
let input = VariantArray::from_iter(vec![
Variant::from(42i32),
Variant::from(3.15f64),
Variant::from("not_a_number"),
]);

// Test Int32 target
Expand Down Expand Up @@ -882,10 +871,7 @@ mod tests {

#[test]
fn test_spec_compliance() {
let input = create_test_variant_array(vec![
Some(Variant::from(42i64)),
Some(Variant::from("hello")),
]);
let input = VariantArray::from_iter(vec![Variant::from(42i64), Variant::from("hello")]);

let result = shred_variant(&input, &DataType::Int64).unwrap();

Expand Down
Loading