GH-47787: [C++][FlightRPC] ODBC msi Windows installer
#48054
+311
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
Need to add `component` to other parts to be able to select the ODBC components Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47787-odbc-msi-installer
branch
from
ce5c956 to
34ebe24
Compare
alinaliBQ
commented
Nov 11, 2025
| ARROW_FLIGHT: ON | ||
| ARROW_FLIGHT_SQL: ON | ||
| ARROW_FLIGHT_SQL_ODBC: ON | ||
| ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON |
Contributor
Author
There was a problem hiding this comment.
TODO: after ODBC can build in MSVC #48067, need to add ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON in MSVC CI. Leaving this change here for now. Rest of PR can be reviewed.
Comment on lines
+111
to
+112
| # rc | ||
| *.rc |
Contributor
Author
There was a problem hiding this comment.
This is for ODBC dll
Contributor
Author
There was a problem hiding this comment.
For installer to be able to select different components, we needed to add COMPONENT to other parts of Arrow cpp that gets build with ODBC.
Contributor
Author
There was a problem hiding this comment.
This is an image of Arrow banner
alinaliBQ
changed the title
msi Windows installermsi Windows installer
github-actions
bot
added
awaiting committer review
alinaliBQ
force-pushed
the
gh-47787-odbc-msi-installer
branch
from
8487389 to
20ad8c6
Compare
With stable product and upgrade id, Windows will be able to properly recognize ODBC installer as the same product, and prevent double-installation from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Implement ODBC installer code for Windows. The primary platform for ODBC is MSVC Windows. The version is set to 1.0.0.
What changes are included in this PR?
Are these changes tested?
Tested locally on MSVC Windows
Are there any user-facing changes?
N/A