refactor: Replace Once with now stable OnceLock
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor splits a unit test into two integration tests as it's no longer possible to overwrite `SERDE_HUMAN_READABLE` after it has been set. By splitting it into two integration tests, they don't share global state and can thus modify it for the test. I've also removed the unit tests that test that the `Serializer`/ `Deserializer` correctly use `SERDE_HUMAN_READABLE` for their `is_human_readable` implementation as these structs are not accessible from a integration test. I've kept the half of the tests that test for `SERDE_HUMAN_READABLE == true`. If this implementation is ever changed it will also affect the integration tests so it's still being tested.
|
It will be hard for me to merge/rebase this to #246 :-/ |
|
Yeah that's fine. I just noticed it while yakshaving for the state machines implentation. I'll keep the PR open and it can rebase on whatever we plan to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor splits a unit test into two integration tests as it's no longer possible to overwrite
SERDE_HUMAN_READABLEafter it has been set. By splitting it into two integration tests, they don't share global state and can thus modify it for the test.I've also removed the unit tests that test that the
Serializer/Deserializercorrectly useSERDE_HUMAN_READABLEfor theiris_human_readableimplementation as these structs are not accessible from a integration test. I've kept the half of the tests that test forSERDE_HUMAN_READABLE == true. If this implementation is ever changed it will also affect the integration tests so it's still being tested.Closes #253