-
Notifications
You must be signed in to change notification settings - Fork 34
Commiting Unit Test with Failing Byte Array Deserialization #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Commiting Unit Test with Failing Byte Array Deserialization #293
Conversation
Hi @martin-g I added the recommended changes. Please let me know if this works. |
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
…lib.rs Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds unit tests to demonstrate a bug with byte array deserialization in the Apache Avro library, as referenced in issue #285. The changes include comprehensive test cases and documentation to help reproduce and understand the problem.
- Adds failing unit tests for byte array deserialization scenarios
- Provides documentation and examples for proper byte array handling with Serde
- Includes both complete and filtered deserialization test cases to isolate the issue
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
avro/tests/avro-rs-285-bytes_deserialization.rs | New test file with comprehensive unit tests demonstrating the byte array deserialization bug |
avro/src/lib.rs | Documentation section explaining proper Serde usage for byte arrays with detailed examples |
avro/README.md | User-facing documentation with examples of byte array deserialization patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Hi @martin-g , apologies for the drop off. Is there anything else you need on my end for the doc updates? |
No! I postponed the merge of few no high prio PRs like this one because of our work on Async APIs (#238). This PR will be merged for the next release! With or without the Async APIs. |
Hi! This is related to #285. I've added a small example file and details in the unit tests