Skip to content

Conversation

petern48
Copy link
Contributor

Which issue does this PR close?

Part of #2019

Rationale for this change

See #2019

What changes are included in this PR?

Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde

How are these changes tested?

No new tests are needed since this is a refactor

@petern48 petern48 changed the title refactor: Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde chore: Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde Jul 12, 2025
@petern48 petern48 marked this pull request as ready for review July 12, 2025 17:48
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI. Thanks @petern48

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 10.52632% with 51 lines in your changes missing coverage. Please review.

Project coverage is 38.84%. Comparing base (f09f8af) to head (091732c).
Report is 326 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/scala/org/apache/comet/serde/arrays.scala 5.55% 51 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2026       +/-   ##
=============================================
- Coverage     56.12%   38.84%   -17.28%     
+ Complexity      976      887       -89     
=============================================
  Files           119      134       +15     
  Lines         11743    13046     +1303     
  Branches       2251     2385      +134     
=============================================
- Hits           6591     5068     -1523     
- Misses         4012     6996     +2984     
+ Partials       1140      982      -158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
Copy link
Member

@petern48 I don't know if you saw, but there are test failures that need investigating

@andygrove andygrove marked this pull request as draft August 8, 2025 16:04
@andygrove
Copy link
Member

This PR seems inactive, so moving to draft for now

@petern48
Copy link
Contributor Author

petern48 commented Aug 8, 2025

Yes, sorry. Just been really busy lately and it's not obvious to me how to fix the CI failures. I don't think I messed something up about copying things over, so there's probably just some other change that I need to do for this specific migration. Not too deeply familiar with Datafusion's codebase yet, but hoping to find the time to investigate deeper soon.

@parthchandra
Copy link
Contributor

@petern48 The tests are failing because as a result of the refactor, the plan is not converting everything to Comet. You can try to run the failing test(s) with and without the PR and with spark.comet.explainFallback.enabled=true in the config. This will provide a hint as to which particular change is causing the regression.
(And you may also need to rebase).

@andygrove
Copy link
Member

I'll go ahead and close this. I started #2257 to refactor these expressions.

@andygrove andygrove closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants