-
Notifications
You must be signed in to change notification settings - Fork 237
chore: Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…of QueryPlanSerde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI. Thanks @petern48
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2026 +/- ##
=============================================
- Coverage 56.12% 38.84% -17.28%
+ Complexity 976 887 -89
=============================================
Files 119 134 +15
Lines 11743 13046 +1303
Branches 2251 2385 +134
=============================================
- Hits 6591 5068 -1523
- Misses 4012 6996 +2984
+ Partials 1140 982 -158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@petern48 I don't know if you saw, but there are test failures that need investigating |
This PR seems inactive, so moving to draft for now |
Yes, sorry. Just been really busy lately and it's not obvious to me how to fix the CI failures. I don't think I messed something up about copying things over, so there's probably just some other change that I need to do for this specific migration. Not too deeply familiar with Datafusion's codebase yet, but hoping to find the time to investigate deeper soon. |
@petern48 The tests are failing because as a result of the refactor, the plan is not converting everything to Comet. You can try to run the failing test(s) with and without the PR and with |
I'll go ahead and close this. I started #2257 to refactor these expressions. |
Which issue does this PR close?
Part of #2019
Rationale for this change
See #2019
What changes are included in this PR?
Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde
How are these changes tested?
No new tests are needed since this is a refactor