-
Notifications
You must be signed in to change notification settings - Fork 246
feat: [iceberg] Enable Comet shuffle in Iceberg diff #2205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
============================================
+ Coverage 56.12% 58.56% +2.43%
- Complexity 976 1284 +308
============================================
Files 119 143 +24
Lines 11743 13226 +1483
Branches 2251 2363 +112
============================================
+ Hits 6591 7746 +1155
- Misses 4012 4250 +238
- Partials 1140 1230 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TPC-DS failure due to #2206 |
One of the test failures is this
The corresponding test code expected
|
@parthchandra @hsiang-c This PR confirms that #2086 is fixed, but the following tests fail when we enable shuffle.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix LGTM, the test failures are known issues and we can fix it in following PRs.
2a21b4c
to
a2dd38e
Compare
lgtm. we can make this ready for review |
0e12f63
to
de0cf65
Compare
I pulled in the changes from #2210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue does this PR close?
Follows on from #2204
Rationale for this change
See if there are any other failures when shuffle is enabled
What changes are included in this PR?
How are these changes tested?