feat: [1941-Part1]: Introduce map-sort scalar function #2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comphead / @andygrove I have split the first part from |
rishvin
changed the title
rishvin
commented
Aug 29, 2025
| return Err(DataFusionError::Internal(format!( | ||
| "Unsupported operation: {:?}", | ||
| op | ||
| "Unsupported operation: {op:?}" |
There was a problem hiding this comment.
Not related to this PR. Clippy fix made this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
============================================
+ Coverage 56.12% 57.78% +1.65%
- Complexity 976 1291 +315
============================================
Files 119 145 +26
Lines 11743 13360 +1617
Branches 2251 2378 +127
============================================
+ Hits 6591 7720 +1129
- Misses 4012 4384 +372
- Partials 1140 1256 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rishvin
force-pushed
the
1941-part1-introduce-map-sort-function
branch
from
3c4ecbb to
2dad05f
Compare
rishvin
changed the title
rishvin
changed the title
comphead
approved these changes
Sep 8, 2025
comphead
added a commit
to comphead/arrow-datafusion-comet
that referenced
this pull request
Sep 11, 2025
…ache#2262)" This reverts commit f2baf95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses Part of #1941
Rationale for this change
Introduces
map_sortwhich is spark compatibleMapSortfunction. SparkMapSortwas introduced in Spark-4.0 to allows grouping on Map type. It allows this by sorting the map by keys before doing the group by.This PR has been split from original PR #2221. Please see that for details.
What changes are included in this PR?
A new
map_sortphysical function.How are these changes tested?
Added unit tests.