Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Oct 24, 2025

Which issue does this PR close?

Part of #2628

Rationale for this change

Increase test coverage by picking both columns and literals for arguments to scalar functions.

SELECT "뇾涓鼁覔", c26, instr("뇾涓鼁覔", c26) AS x FROM test1 ORDER BY "뇾涓鼁覔", c26;

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.17%. Comparing base (f09f8af) to head (211bb11).
⚠️ Report is 638 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2645      +/-   ##
============================================
+ Coverage     56.12%   59.17%   +3.04%     
- Complexity      976     1447     +471     
============================================
  Files           119      147      +28     
  Lines         11743    13743    +2000     
  Branches       2251     2360     +109     
============================================
+ Hits           6591     8132    +1541     
- Misses         4012     4388     +376     
- Partials       1140     1223      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead
Copy link
Contributor

For literals btw we still need to support maps and structs #1937
should we resume work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants