-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Support PiecewiseMergeJoin
to speed up single range predicate joins
#16660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 11 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
ac2b88c
feat: Support `PiecewiseMergeJoin` for single range join filters
jonathanc-n 6af253b
fix
jonathanc-n 60047ba
add children()
jonathanc-n 1d09886
Merge branch 'main' into pwmj
jonathanc-n 6199b61
fmt
jonathanc-n e7cf488
tma
jonathanc-n e77bd5a
clippy
jonathanc-n 7212242
fix: Required input ordering
jonathanc-n 30e73e4
fix
jonathanc-n feaee9a
fix sorting
jonathanc-n 75a60b2
update
jonathanc-n 0845600
Update datafusion/physical-plan/src/joins/mod.rs
jonathanc-n eb9040f
feat: Add `compute_properties` + add comments
jonathanc-n b66a69b
Merge branch 'pwmj' of https://github.com/jonathanc-n/datafusion into…
jonathanc-n f33b8d8
fmt!
jonathanc-n 250a8a5
feat: Add metrics + memory reservation
jonathanc-n 516ebdb
Merge branch 'apache:main' into pwmj
jonathanc-n a2ec52b
min/max refactor
jonathanc-n 3551ddb
Merge branch 'pwmj' of https://github.com/jonathanc-n/datafusion into…
jonathanc-n 23298f1
rm output_rows
jonathanc-n 2f28845
Merge branch 'main' into pwmj
jonathanc-n 3dac640
Merge branch 'main' into pwmj
jonathanc-n 3e3a8b6
new join
jonathanc-n 77e25a7
Merge branch 'pwmj' of https://github.com/jonathanc-n/datafusion into…
jonathanc-n fdd2f3f
Merge branch 'main' into pwmj
jonathanc-n 9016ce7
add sql examples
jonathanc-n e865e27
Update datafusion/physical-plan/src/joins/piecewise_merge_join.rs
jonathanc-n 22e423d
fix
jonathanc-n bd245f7
update
jonathanc-n d426def
Merge branch 'main' into pwmj
jonathanc-n f490de6
update
jonathanc-n 79a5aab
remove pub from `BatchProcessState`
jonathanc-n e78115f
Merge branch 'main' into pwmj
jonathanc-n 5297936
doc changes
jonathanc-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -943,8 +943,11 @@ impl<T: BatchTransformer> NestedLoopJoinStream<T> { | |
// Only setting up timer, input is exhausted | ||
let timer = self.join_metrics.join_time.timer(); | ||
// use the global left bitmap to produce the left indices and right indices | ||
let (left_side, right_side) = | ||
get_final_indices_from_shared_bitmap(visited_left_side, self.join_type); | ||
let (left_side, right_side) = get_final_indices_from_shared_bitmap( | ||
visited_left_side, | ||
|
||
self.join_type, | ||
false, | ||
); | ||
let empty_right_batch = RecordBatch::new_empty(self.outer_table.schema()); | ||
// use the left and right indices to produce the batch result | ||
let result = build_batch_from_indices( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.