-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added Example for Statistical Functions
in Docs
#16927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Adez017 -- this is a great start
Is there any chance you can include the SQL / table definitions for the other examples as well?
i notice that although i had added the SQL table reference for the statistical functions , there is many table creation reference is missing from the aggregates functions . we can follow up this in a new issue , i would like to work upon this |
CC: @alamb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Adez017 -- I left a few more comments -- when I double checked some of these examples, they don't seem to work / refer to missing tables or columns
Is there any chance you can double check that they all work? Perhaps by running them in datafusion-cli?
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
hi @alamb , i had updated some examples and still some left will ,and will update the remaining by the end of the day |
Done @alamb , done with all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Adez017 -- I was looking more at this PR and another thing I noticed is that the new examples are wiped out when the docs are regenerated from source
The way to get them to show up is to put them inline in the source code. I pushed a commit that shows how to do it. Hopefully that makes sense
Here are the commands to update the docs
# regenerate the docs
./dev/update_function_docs.sh
# build the docs
(cd docs && ./build.sh)
# view the docs
open docs/build/html/index.html
Here is an example of how it looks on my local machine:
file:///Users/andrewlamb/Software/datafusion/docs/build/html/user-guide/sql/aggregate_functions.html#regr-slope

hi @alamb , i had fixed the docs , the only thing that's need to be fixed is to rerun the commands
because the pretier is not working in my system ,also please verify |
any updates @alamb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @Adez017 -- very much apprecaited
I tried all the examples in this PR, and I found a few more fixups I had to do to match the output of datafusion-cli. I pushed them to this PR along with running prettier
and now I think it looks very nice.
Thank you again
Hi @alamb , much appreciated efforts . thank you very much |
Hi @alamb , @xudong963 . As of now its look good to me , if any further updates needed let me know . if not , we can move forward to merge it |
I think this one is good to go -- thanks @Adez017 |
* Update aggregate_functions.md * Update aggregate_functions.md * formating fix * Update aggregate_functions.md * Update docs/source/user-guide/sql/aggregate_functions.md Co-authored-by: Andrew Lamb <[email protected]> * Update docs/source/user-guide/sql/aggregate_functions.md Co-authored-by: Andrew Lamb <[email protected]> * Update docs/source/user-guide/sql/aggregate_functions.md Co-authored-by: Andrew Lamb <[email protected]> * Update aggregate_functions.md * Update aggregate_functions.md * Update aggregate_functions.md * Add examples to code * Alamb Update * Updated docs , build * prettier * Updates + prettier --------- Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Statistical Functions
in the Docs #16923Rationale for this change
There are missing Example in the user guide for
Statistical Functions
in the user guide.What changes are included in this PR?
Updated the
aggregate_functions.md