Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 2, 2025

Which issue does this PR close?

Rationale for this change

I suggested using dev containers on this PR
#17018 (comment)

Screenshot 2025-08-02 at 6 22 00 AM

However, when I actually tried to use it, I got an error about npm not being installed (see screenshot):

Screenshot 2025-08-02 at 6 41 21 AM
root@codespaces-09a5ab:/workspaces/datafusion# ./dev/update_function_docs.sh
/workspaces/datafusion
Inserting header
Running CLI and inserting aggregate function docs table
    Updating crates.io index
    Blocking waiting for file lock on package cache
    Blocking waiting for file lock on package cache
    ...

   Compiling datafusion v49.0.0 (/workspaces/datafusion/datafusion/core)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 9m 59s
     Running `target/debug/print_functions_docs aggregate`
Running prettier
./dev/update_function_docs.sh: line 68: npx: command not found
root@codespaces-09a5ab:/workspaces/datafusion# apt-get install npm
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package npm

What changes are included in this PR?

  1. Add nodejs, npm to the dev container
  2. Pre-install prettier

Are these changes tested?

I am testing them manually

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review August 4, 2025 13:36
@alamb alamb changed the title Add prettier to the devcontainer Add prettier to the devcontainer (GitHub codespaces) Aug 4, 2025
@alamb alamb added the development-process Related to development process of DataFusion label Aug 4, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@alamb alamb merged commit c7d5904 into apache:main Aug 11, 2025
28 of 29 checks passed
@alamb
Copy link
Contributor Author

alamb commented Aug 11, 2025

Thank you for the review @Jefffrey

@alamb alamb deleted the alamb/add_npm_to_dev_container branch August 11, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants