Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 4, 2025

Which issue does this PR close?

Rationale for this change

I again got nerd sniped on my way to adding a configuration tuning guide -- I found the intro text for configuration settings quite hard to understand and obscured some of the relevant detail

What changes are included in this PR?

  1. Add some examples of how to change config settings
  2. Move some code level detail into the API docs

Are these changes tested?

By CI

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion common Related to common crate execution Related to the execution crate labels Aug 4, 2025
///
/// For example, setting `DATAFUSION_EXECUTION_BATCH_SIZE` will
/// control `datafusion.execution.batch_size`.
/// For example, to configure `datafusion.execution.batch_size`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information was previously in the user guide but it feels like code level details so I moved it


For applications which do not expose `SessionConfig`, like `datafusion-cli`, these options may also be set via environment variables.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this content is moved into ConfigOptions docs

@alamb alamb marked this pull request as ready for review August 4, 2025 19:02
@alamb
Copy link
Contributor Author

alamb commented Aug 4, 2025

Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xudong963
Copy link
Member

Let's go

@xudong963 xudong963 merged commit 4c36226 into apache:main Aug 5, 2025
28 checks passed
@alamb alamb deleted the alamb/config_tuning branch August 6, 2025 20:23
hknlof pushed a commit to hknlof/datafusion that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate development-process Related to development process of DataFusion documentation Improvements or additions to documentation execution Related to the execution crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants