-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Docs: Add Examples to Config Options page #17039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/// | ||
/// For example, setting `DATAFUSION_EXECUTION_BATCH_SIZE` will | ||
/// control `datafusion.execution.batch_size`. | ||
/// For example, to configure `datafusion.execution.batch_size` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This information was previously in the user guide but it feels like code level details so I moved it
|
||
For applications which do not expose `SessionConfig`, like `datafusion-cli`, these options may also be set via environment variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this content is moved into ConfigOptions docs
https://github.com/apache/datafusion/actions/runs/16731686985/job/47361169534?pr=17039 is a CI / network error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Let's go |
Which issue does this PR close?
Rationale for this change
I again got nerd sniped on my way to adding a configuration tuning guide -- I found the intro text for configuration settings quite hard to understand and obscured some of the relevant detail
What changes are included in this PR?
Are these changes tested?
By CI
Are there any user-facing changes?