Skip to content

Enable clippy::clone_on_ref_ptr lint on workspace #17178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enable clippy::clone_on_ref_ptr lint on workspace #17178

wants to merge 4 commits into from

Conversation

lgingerich
Copy link
Contributor

Which issue does this PR close?

Closes #17083.

Rationale for this change

What changes are included in this PR?

  • Remove crate-level clippy::clone_on_ref_ptr lint
  • Add workspace-level clippy::clone_on_ref_ptr lint
  • Fix clippy:: clone_on_ref_ptr errors

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Aug 13, 2025
@lgingerich
Copy link
Contributor Author

I disabled the lint for tests at the crate level to handle inline tests, but it would need to be done within each actual test file to fix everything. Running into a similar issue for whether to fix the lint errors for examples/benchmarks or disable the lint.

Given the above, this is getting to be quite a lot of duplicate code pasted around. Options:

  • Is there a way to disable the lint at a workspace-level for tests that I am missing?
  • Should this be abandoned altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable clone_on_ref_ptr Clippy lint for the whole workspace
1 participant
@lgingerich