feat: Make Parquet EncryptionFactory async #17342
Merged
+96
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
adamreeve
commented
Aug 29, 2025
Comment on lines
+161
to
+162
| // For now, page index does not work with encrypted files. See: | ||
| // https://github.com/apache/arrow-rs/issues/7629 |
There was a problem hiding this comment.
I noticed it should be possible to remove this workaround now. I've made #17352 to follow up on this as it should be a separate change
xudong963
approved these changes
Aug 31, 2025
|
Thanks @adamreeve and @xudong963 -- I'll plan to merge this when the CI passes |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
To allow users to implement async network access within the encryption factory without blocking.
Are these changes tested?
Yes, covered by existing tests that have been updated.
Are there any user-facing changes?
Yes, this is a user facing change but to a trait that isn't in a released version yet.