fix: window unparsing #17367
Open
fix: window unparsing #17367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-faria
reviewed
Sep 2, 2025
Comment on lines
2557
to
2559
| assert_snapshot!( | ||
| sql, | ||
| @r#"SELECT "test"."k", "test"."v", rank() OVER (PARTITION BY "test"."k" ORDER BY "test"."v" ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) FROM "test" QUALIFY (rank() OVER (PARTITION BY "test"."k" ORDER BY "test"."v" ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) = 1)"# |
There was a problem hiding this comment.
Thanks @chenkovsky, this now generates valid Datafusion SQL.
Unfortunately, the QUALIFY keyword is not available in PostgreSQL, as well as other systems (https://modern-sql.com/caniuse/qualify), meaning the output does not work there.
nuno-faria
approved these changes
Sep 7, 2025
Comment on lines
276
to
+279
| impl Dialect for PostgreSqlDialect { | ||
| fn supports_qualify(&self) -> bool { | ||
| false | ||
| } |
There was a problem hiding this comment.
Like PostgreSQL, MySQL and SQLite also do not support the Qualify keyword, so they should also have supports_qualify returning false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
in LogicalPlan::Filter unparsing,
if there's a window expr, it should be converted to quailify.
What changes are included in this PR?
If window expr is found, convert filter to quailify.
Are these changes tested?
UT
Are there any user-facing changes?
No