refactor: simplify json_shredding example by using ListingTable #17369
+20
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Is the output the same? |
Yes, I've pair compared the analyze output (as well as others |
adriangb
approved these changes
Sep 2, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Trying to prove "why
DataSourceExecis not a good abstraction for end users" when investigating #17242. And I found this file is one of the few references of that trait.What changes are included in this PR?
Replace the manually implemented
TableProviderusingDataSourceExecwith the existing infrastructureListingTableAre these changes tested?
Yes, I've run this example after those changes
Are there any user-facing changes?
No