feat: allow pushdown of dynamic filters having partition cols #18172
+85
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feniljain
force-pushed
the
feat-dynamic-filter-join-partition-col
branch
from
2e64a1e to
1a02eae
Compare
feniljain
changed the title
feniljain
force-pushed
the
feat-dynamic-filter-join-partition-col
branch
4 times, most recently
from
115d3c1 to
2d8fb9c
Compare
adriangb
reviewed
Oct 20, 2025
adriangb
reviewed
Oct 21, 2025
feniljain
force-pushed
the
feat-dynamic-filter-join-partition-col
branch
from
663f36e to
e58d9ec
Compare
feniljain
force-pushed
the
feat-dynamic-filter-join-partition-col
branch
from
e58d9ec to
2c1ee6e
Compare
|
@feniljain mind if I push 7818a42c7 to your branch / this PR? |
|
Sure thing! No worries, thanks for the patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Included in the issue
Are these changes tested?
While I have tested this on local with a local TPCDS-like dataset, I would appreciate if someone provides me a good way to add tests for the same 😅