Fix array_has simplification with null argument #18186
Merged
+86
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
force-pushed
the
bugfix/array-has
branch
3 times, most recently
from
62dd628 to
19c53c1
Compare
Jefffrey
reviewed
Oct 21, 2025
joroKr21
force-pushed
the
bugfix/array-has
branch
from
19c53c1 to
80aeb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
According to three-valued logic we should return
nulland that's also what happens when the argument is not a constant as seen in the test.What changes are included in this PR?
Updated
ArrayHas::simplifyto explicitly handlenullAre these changes tested?
Updated the
array_hasSQL test and added unit testsAre there any user-facing changes?
Yes, a minor change in behaviour wrt
null