Skip to content

branch-4.0: [chore](typo)Fix typos in thrift #57267 #57300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: branch-4.0: [Feature](varbinary) add length, from_base64_binary, to_base64_bianry, sub_binary for VarBinary type
merged 1 commit into from
Oct 26, 2025
Merged

branch-4.0: [chore](typo)Fix typos in thrift #57267 #57300

merged 1 commit into from
Oct 26, 2025
+19 −19

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #57267

@github-actions github-actions bot requested a review from yiguolei as a code owner October 24, 2025 05:46
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 24, 2025
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yiguolei
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@uchenily @yiguolei
[chore](typo)Fix typos in thrift (#57267)
7efb8ec 
In Thrift, fields are distinguished by IDs rather than names, so
modifying field names does not break compatibility.
@yiguolei yiguolei force-pushed the auto-pick-57267-branch-4.0 branch from f1ac8a4 to 7efb8ec Compare October 25, 2025 02:17
@yiguolei
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit 2e826aa into branch-4.0 Oct 26, 2025
23 of 28 checks passed
@github-actions github-actions bot deleted the auto-pick-57267-branch-4.0 branch October 26, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @yiguolei @dataroaring @uchenily