Skip to content

branch-3.1: [fix](nereids)relase physical plan in Profile.releaseMemory() #57257 #57316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

branch-3.1: [fix](nereids)relase physical plan in Profile.releaseMemory() #57257 #57316

merged 1 commit into from
Oct 28, 2025

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #57257

@englefly
[fix](nereids)relase physical plan in Profile.releaseMemory() (#57257)
dfd2251 
### What problem does this PR solve?
The profile holds a physical plan object. In profile.releaseMemory(),
the physicalPlan needs to be set to null to release it, preventing the
groupExpression in Memo from failing to be released in a timely manner.
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner October 24, 2025 14:26
@Thearas
Copy link
Contributor

Thearas commented Oct 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 24, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32421 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dfd2251097b55583548f37a9dd23d28db1f89c32, data reload: false

------ Round 1 ----------------------------------
q1	17642	5432	5397	5397
q2	2031	385	276	276
q3	11606	1245	747	747
q4	10325	856	440	440
q5	9705	2348	2082	2082
q6	200	162	127	127
q7	898	729	622	622
q8	9343	1415	1105	1105
q9	5171	5005	4900	4900
q10	6755	2248	1810	1810
q11	476	276	259	259
q12	350	347	207	207
q13	17758	3551	3008	3008
q14	225	244	220	220
q15	534	458	469	458
q16	411	422	374	374
q17	596	857	362	362
q18	6832	6471	6348	6348
q19	1337	942	533	533
q20	319	337	211	211
q21	2754	2136	1953	1953
q22	1052	1036	982	982
Total cold run time: 106320 ms
Total hot run time: 32421 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5606	5535	5525	5525
q2	242	331	231	231
q3	2274	2665	2279	2279
q4	1330	1817	1342	1342
q5	4431	4932	4936	4932
q6	167	164	135	135
q7	2097	1987	1837	1837
q8	2643	2812	2724	2724
q9	7248	7235	7247	7235
q10	3040	3344	2692	2692
q11	554	495	493	493
q12	679	772	636	636
q13	3405	3791	3146	3146
q14	281	303	267	267
q15	531	485	480	480
q16	426	483	425	425
q17	1246	1732	1265	1265
q18	7682	7512	7309	7309
q19	768	1116	1105	1105
q20	2081	2075	1940	1940
q21	5392	4933	4489	4489
q22	1081	1066	1037	1037
Total cold run time: 53204 ms
Total hot run time: 51524 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192932 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dfd2251097b55583548f37a9dd23d28db1f89c32, data reload: false

query1	959	406	419	406
query2	6218	1970	1884	1884
query3	8688	197	193	193
query4	33986	23917	23557	23557
query5	3656	598	452	452
query6	285	185	191	185
query7	4200	487	316	316
query8	300	243	224	224
query9	9247	2598	2590	2590
query10	493	313	256	256
query11	17871	15825	15273	15273
query12	158	110	109	109
query13	1556	555	419	419
query14	9466	7724	7126	7126
query15	257	202	180	180
query16	8088	659	560	560
query17	1555	779	573	573
query18	2159	425	309	309
query19	219	189	168	168
query20	131	124	120	120
query21	215	130	105	105
query22	4551	4642	4569	4569
query23	35230	34434	34141	34141
query24	7672	2671	2683	2671
query25	539	482	407	407
query26	863	290	175	175
query27	2050	482	374	374
query28	5145	2256	2206	2206
query29	738	631	475	475
query30	260	201	161	161
query31	971	938	827	827
query32	98	64	63	63
query33	509	389	338	338
query34	719	848	514	514
query35	792	813	727	727
query36	1011	1070	939	939
query37	105	103	70	70
query38	4011	3971	4001	3971
query39	1524	1658	1493	1493
query40	217	127	111	111
query41	54	53	52	52
query42	131	109	105	105
query43	528	515	498	498
query44	1356	836	843	836
query45	193	181	173	173
query46	875	1052	666	666
query47	2019	1982	1940	1940
query48	446	429	360	360
query49	736	505	430	430
query50	699	706	445	445
query51	7358	7216	7344	7216
query52	101	103	96	96
query53	242	257	194	194
query54	555	541	484	484
query55	81	82	78	78
query56	284	290	266	266
query57	1278	1312	1232	1232
query58	250	222	240	222
query59	3134	3187	3066	3066
query60	299	311	267	267
query61	120	111	116	111
query62	820	778	694	694
query63	229	196	196	196
query64	3823	1034	649	649
query65	3371	3282	3302	3282
query66	951	414	319	319
query67	16404	16075	15568	15568
query68	7754	807	530	530
query69	495	310	263	263
query70	1146	1076	1123	1076
query71	424	295	264	264
query72	5120	3807	3900	3807
query73	629	749	366	366
query74	10205	9271	9059	9059
query75	3979	3120	2664	2664
query76	3401	1203	749	749
query77	760	375	281	281
query78	10348	10435	9756	9756
query79	2908	839	593	593
query80	658	519	429	429
query81	491	258	223	223
query82	575	122	94	94
query83	164	160	155	155
query84	288	98	80	80
query85	793	356	302	302
query86	359	283	307	283
query87	4310	4342	4222	4222
query88	4504	2398	2398	2398
query89	397	335	297	297
query90	1855	189	189	189
query91	140	145	110	110
query92	61	57	54	54
query93	1793	889	526	526
query94	635	405	292	292
query95	346	277	263	263
query96	482	610	280	280
query97	3219	3228	3109	3109
query98	217	211	205	205
query99	1534	1406	1331	1331
Total cold run time: 293039 ms
Total hot run time: 192932 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.78 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dfd2251097b55583548f37a9dd23d28db1f89c32, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.61	0.11	0.10
query5	0.49	0.50	0.52
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.56	0.56
query11	0.15	0.11	0.10
query12	0.13	0.11	0.11
query13	0.63	0.60	0.59
query14	0.78	0.80	0.81
query15	0.87	0.83	0.83
query16	0.37	0.41	0.38
query17	1.00	1.01	1.05
query18	0.24	0.22	0.21
query19	1.85	1.81	1.77
query20	0.01	0.01	0.02
query21	15.40	0.99	0.59
query22	0.73	0.85	0.69
query23	15.00	1.42	0.54
query24	3.43	0.82	1.23
query25	0.16	0.10	0.06
query26	0.30	0.14	0.15
query27	0.04	0.04	0.05
query28	13.37	1.02	0.42
query29	12.57	3.97	3.26
query30	0.24	0.08	0.07
query31	2.82	0.60	0.39
query32	3.22	0.52	0.46
query33	2.97	3.04	3.11
query34	16.62	5.11	4.57
query35	4.54	4.58	4.59
query36	0.65	0.50	0.47
query37	0.08	0.05	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.3 s
Total hot run time: 28.78 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 311b78e into branch-3.1 Oct 28, 2025
23 checks passed
@morrySnow morrySnow deleted the auto-pick-57257-branch-3.1 branch October 28, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @hello-stephen @morrySnow @dataroaring @englefly