Skip to content

feat: configure access logs with Telemetry API - #1021

Merged
github-actions[bot] merged 1 commit into
apache:masterfrom
mfordjody:logging_feature
Aug 20, 2026
Merged

feat: configure access logs with Telemetry API#1021
github-actions[bot] merged 1 commit into
apache:masterfrom
mfordjody:logging_feature

Conversation

@mfordjody

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code dubbod Control-plane and discovery server related helm Helm chart related testing Tests and test infrastructure related labels Aug 20, 2026
@mfordjody

Copy link
Copy Markdown
Member Author

/lgtm

@github-actions github-actions Bot added the lgtm This Pull Request is ready for merging. label Aug 20, 2026
@github-actions
github-actions Bot merged commit 6f807d5 into apache:master Aug 20, 2026
14 checks passed
@github-actions

Copy link
Copy Markdown

Merged on behalf of @mfordjody via /lgtm.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.25243% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.33%. Comparing base (f176b9d) to head (88c5e2c).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/config/validation/validators.go 0.00% 29 Missing and 1 partial ⚠️
...y/pkg/config/kube/gateway/deployment_controller.go 63.63% 6 Missing and 2 partials ⚠️
...iscovery/pkg/bootstrap/inherent_grpc_controller.go 90.62% 1 Missing and 2 partials ⚠️
pkg/config/telemetry/telemetry.go 89.47% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (58.25%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   22.43%   21.33%   -1.10%     
==========================================
  Files         339      328      -11     
  Lines       33458    32251    -1207     
==========================================
- Hits         7506     6881     -625     
+ Misses      25089    24630     -459     
+ Partials      863      740     -123     
Flag Coverage Δ
unittests 21.33% <58.25%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file dubbod Control-plane and discovery server related go Pull requests that update go code helm Helm chart related lgtm This Pull Request is ready for merging. testing Tests and test infrastructure related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants