Skip to content

Conversation

ferenc-csaky
Copy link
Contributor

No description provided.

@ferenc-csaky ferenc-csaky requested a review from gyfora September 27, 2025 18:40
Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a minimal context on why this change is required and where the new action.yml is coming from?

@ferenc-csaky
Copy link
Contributor Author

Context added to the Jira ticket. And the action.yml comes from me and ChatGPT :)

@gyfora
Copy link
Contributor

gyfora commented Sep 28, 2025

How about we simply copy the appropriate action from the burnett01/rsync-deployments codebase: https://github.com/Burnett01/rsync-deployments/tree/7.1.0

We could copy the logic as is, and add the MIT license in: LICENSE.rsync-deployments

@ferenc-csaky
Copy link
Contributor Author

How about we simply copy the appropriate action from the burnett01/rsync-deployments codebase: https://github.com/Burnett01/rsync-deployments/tree/7.1.0

We could copy the logic as is, and add the MIT license in: LICENSE.rsync-deployments

That action runs in a Docker img. So we need to copy over pretty much the whole codebase (action.yml, Dockerfile, entrypoint.sh). It has the benefit of a fixed rsync version, I'm 99% sure it won't matter at all. I'm okay to do that though, just let me know if that would be preferred.

@ferenc-csaky
Copy link
Contributor Author

Or as an alternative we could copy entrypoint.sh and slightly modify the action.yml to call it directly, excluding the Docker portion.

@gyfora
Copy link
Contributor

gyfora commented Sep 29, 2025

I was just looking at the current code and comparing with the entry point.sh/action.yml. It already looks very very similar .
We can reorganize/modify it, as long as we at least include the reference / notice its clean and clear where it's coming from

@ferenc-csaky ferenc-csaky merged commit 3e3cb58 into apache:main Sep 29, 2025
118 checks passed
@ferenc-csaky ferenc-csaky changed the title [FLINK-38448] Replace burnett01/rsync-deployments with a custom rsync-deploy action in docs.yaml [FLINK-38448] Rework doc build and doc deployment Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants