-
Notifications
You must be signed in to change notification settings - Fork 313
refactor: objectstreamserializer to use meta shared compatible #2799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
java/fory-core/src/main/java/org/apache/fory/config/ForyBuilder.java
Outdated
Show resolved
Hide resolved
Hello, @chaokunyang . I see these two classes are marked as deprecated. However, I believe further discussion is needed regarding their removal. Completely removing these classes would impact backward compatibility. Therefore, I recommend retaining the CompatibleSerializer in non-meta-shared mode and using the ObjectStreamMetaSharedSerializerAdapter only in meta-shared mode. Restore the conditional for useMetaShare in SlotsInfo. Non-meta-shared mode: Use the CompatibleSerializer. Meta-shared mode: Use the ObjectStreamMetaSharedSerializerAdapter. What do you think about this? |
|
While fixing CI, I encountered a problem. |
java/fory-core/src/main/java/org/apache/fory/config/Config.java
Outdated
Show resolved
Hide resolved
|
@chaokunyang Hello, it's ready. |
Why?
What does this PR do?
Related issues
Related to issue-2622
Does this PR introduce any user-facing change?
Benchmark