Skip to content

Conversation

@cbmarcum
Copy link

@cbmarcum cbmarcum commented Oct 12, 2025

after CachingDriverFactory.clearCacheAndQuitDriver().

This is an update to the the CachingDriverFactorySpec to add a geb.test.GebSpec test to confirm the driver has been quit properly.

It will fail until PR #289 is merged which fixes #288.

Refs: #288

Copy link
Contributor

@jonnybot0 jonnybot0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonnybot0
Copy link
Contributor

Looks like this test fails in CI. https://github.com/apache/groovy-geb/actions/runs/18449198072/job/52560351367?pr=291

Okay, sorry, brain is catching up. I understand now that this is meant to demonstrate the fix in #289.

I appreciate the demonstration! How about you just merge this into the branch for https://github.com/apache/groovy-geb/pull/289/files and merge them together?

@cbmarcum
Copy link
Author

Looks like this test fails in CI. https://github.com/apache/groovy-geb/actions/runs/18449198072/job/52560351367?pr=291

Okay, sorry, brain is catching up. I understand now that this is meant to demonstrate the fix in #289.

I appreciate the demonstration! How about you just merge this into the branch for https://github.com/apache/groovy-geb/pull/289/files and merge them together?

I added in #292. Thanks for the suggestion. Should I close this one or wait to see if #292 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser/driver processes remain in Geb 8 after tests despite using CachingDriverFactory.clearCacheAndQuitDriver()

2 participants