Skip to content

Conversation

jasoncheng7115
Copy link

I have added the zh_TW.json translation file for Traditional Chinese,
but it does not appear as an option in the language selection menu.

Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasoncheng7115 Thanks for contributing this. There's a couple of things that need to be done:

  • You need to request a Jira account and create a Jira issue for this, and tag both the PR and the commit messages with the GUACAMOLE-XXXX issue.
  • Please make sure not to include anything that you're not translating in the translation file.

See: https://guacamole.apache.org/open-source/

As far as why the translation is not loading, I'd say the first thing to check is clearing your browser cache and reloading the page to see if that gets the language to load. Other than that, maybe increase the log level of the web application and see if there are any messages about the new language file in there?

https://guacamole.apache.org/doc/gug/configuring-guacamole.html#logging-within-the-web-application

Comment on lines +7 to +8
"NAME" : "Apache Guacamole",
"VERSION" : "${project.version}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include these values in the translation - they will be pulled automatically from the English translation.

@jasoncheng7115
Copy link
Author

Thank you for your detailed explanation. I will review and learn more about the Guacamole contribution process and then make the necessary corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants