GUACAMOLE-2091: optimize cursor rendering and handle empty column ranges. #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orange-guo
commented
Jul 17, 2025
orange-guo
commented
- Add check for empty column ranges in display_set_columns
- Improve cursor rendering by considering character width
- Adjust cursor redraw area to fit within visible columns
- Log debug message for empty column ranges
|
The issue related to this PR is: https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-2091 |
necouchman
requested changes
Aug 15, 2025
There was a problem hiding this comment.
Just one change from me, other than that looks okay. Also @orange-guo, if you could rebase and change the pull request to be against the patch branch instead of main? That way we can get the fix into the 1.6.1 release.
@mike-jumper Any comments from you?
src/terminal/display.c
Outdated
| end_column = guac_terminal_fit_to_range(end_column, 0, display->width - 1); | ||
|
|
||
| if (start_column > end_column) { | ||
| guac_client_log(display->client, GUAC_LOG_DEBUG, "display_set_columns: Adjusted range is empty [%d,%d], returning.", start_column, end_column); |
There was a problem hiding this comment.
This seems like it should be in GUAC_LOG_TRACE rather than DEBUG?
orange-guo
force-pushed
the
GUACAMOLE-2091
branch
from
26ff1fd to
73ac8f9
Compare
|
@necouchman all comments have been resolved. |
necouchman
approved these changes
Aug 20, 2025
- Add check for empty column ranges in display_set_columns - Improve cursor rendering by considering character width - Adjust cursor position and size based on the current character - Optimize cursor redraw in guac_terminal_set_columns
orange-guo
force-pushed
the
GUACAMOLE-2091
branch
from
73ac8f9 to
9d5f0a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.