Skip to content

Conversation

@CalvinZKrist
Copy link

No description provided.

@necouchman
Copy link
Contributor

@CalvinZKrist : Thanks for contributing this to the Guacamole project - this is something that I know several folks have asked for, and would be a welcome addition to the functionality provided by Guacamole.

Before reviewing the actual changes you've made, there are a few overall issues that need to be addressed:

  • You'll need a Jira issue associated with the changes. You can go to our Jira page (https://issues.apache.org/jira/projects/GUACAMOLE) and request an account, and then create the issue.
  • Once you have a Jira issue, both the pull request and the commit messages need to be tagged with the Jira issue.
  • The commit messages are going to need some work - they need to be more descriptive of what is actually changing without providing too much detail. We find the following reference helpful: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/.
  • You'll also want to double-check that your code follows established standard within the existing code and our guidelines. The following reference may be useful: https://guacamole.apache.org/open-source/. You may already have done this - I have not looked at the changes, yet - but just wanted to throw that out there.

Thanks, and I look forward to working with you to get these changes into Guacamole!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants