GUACAMOLE-2136: Improve C standards compliance #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses C standard compliance issues identified when building with Clang 18.1.3 and strict compiler flags. Changes made: 1. Added 'void' keyword to all function declarations with no parameters to comply with modern C standards (fixes -Wstrict-prototypes warnings) 2. Removed unused 'flushed' variable in surface.c that was set but never used (fixes -Wunused-but-set-variable warning) The code now builds cleanly with both GCC and Clang when using -Werror -Wstrict-prototypes flags.
necouchman
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Looks fine to me. @mike-jumper any concerns with merging this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses C standard compliance issues identified when building with Clang 18.1.3 and strict compiler flags.
Changes made:
The code now builds cleanly with both GCC and Clang when using -Werror -Wstrict-prototypes flags.
JIRA Issue
https://issues.apache.org/jira/browse/GUACAMOLE-2136