HBASE-29939 Upgrade hbase-logging to use junit5#7821
Merged
Apache9 merged 3 commits intoapache:masterfrom Mar 6, 2026
Merged
Conversation
Member
liuxiaocs7
commented
Feb 28, 2026
- see: HBASE-29939
Apache9
reviewed
Mar 5, 2026
Contributor
Apache9
left a comment
There was a problem hiding this comment.
We do not have any real tests in hbase-logging module, do we really need the junit related dependencies?
Member
Author
+1, we can remove them all |
Contributor
|
Seems we need to skip tests in hbase-logging, as we have a surefire plugin in parent pom for all sub modules? |
Contributor
|
Apache9
approved these changes
Mar 6, 2026
Apache9
pushed a commit
that referenced
this pull request
Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit ac62af6)
Apache9
pushed a commit
that referenced
this pull request
Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit ac62af6)
Apache9
pushed a commit
that referenced
this pull request
Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit ac62af6)
Apache9
pushed a commit
that referenced
this pull request
Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit ac62af6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.