Skip to content

HBASE-29939 Upgrade hbase-logging to use junit5#7821

Merged
Apache9 merged 3 commits intoapache:masterfrom
liuxiaocs7:HBASE-29939
Mar 6, 2026
Merged

HBASE-29939 Upgrade hbase-logging to use junit5#7821
Apache9 merged 3 commits intoapache:masterfrom
liuxiaocs7:HBASE-29939

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have any real tests in hbase-logging module, do we really need the junit related dependencies?

@liuxiaocs7
Copy link
Copy Markdown
Member Author

We do not have any real tests in hbase-logging module, do we really need the junit related dependencies?

+1, we can remove them all

@Apache9
Copy link
Copy Markdown
Contributor

Apache9 commented Mar 6, 2026

Seems we need to skip tests in hbase-logging, as we have a surefire plugin in parent pom for all sub modules?

@Apache9
Copy link
Copy Markdown
Contributor

Apache9 commented Mar 6, 2026

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <configuration>
          <skipTests>true</skipTests>
        </configuration>
      </plugin>

@Apache9 Apache9 merged commit ac62af6 into apache:master Mar 6, 2026
7 checks passed
Apache9 pushed a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit ac62af6)
Apache9 pushed a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit ac62af6)
Apache9 pushed a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit ac62af6)
Apache9 pushed a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit ac62af6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants