Skip to content

Include license and notice files in published crates #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ankane
Copy link

@ankane ankane commented Aug 13, 2025

Which issue does this PR close?

None

What changes are included in this PR?

This symlinks the LICENSE and NOTICE files so they're included in the published crates (similar to apache/arrow-rs#6767).

Are these changes tested?

N/A

@liurenjie1024
Copy link
Contributor

hi, @ankane could you help to explain what's the result of this pr? I see we already have license info at at docs.rs

@ankane
Copy link
Author

ankane commented Aug 14, 2025

Hi @liurenjie1024, this will add the files to the crate source. The Apache 2.0 license mentions including both files with copies of the software, and it's nice for tooling like cargo vendor (microsoft/windows-rs#1587 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants