feat(catalog): implement catalog loader for glue #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
reviewed
Aug 13, 2025
| @@ -46,6 +47,7 @@ impl<T: CatalogBuilder + 'static> BoxedCatalogBuilder for T { | |||
| pub fn load(r#type: &str) -> Result<Box<dyn BoxedCatalogBuilder>> { | |||
| match r#type { | |||
| "rest" => Ok(Box::new(RestCatalogBuilder::default()) as Box<dyn BoxedCatalogBuilder>), | |||
| "glue" => Ok(Box::new(GlueCatalogBuilder::default()) as Box<dyn BoxedCatalogBuilder>), | |||
There was a problem hiding this comment.
Shoud we make these enum or static strings stored under the iceberg/src/catalog/
There was a problem hiding this comment.
Yeah I think having a enum storing the strings make sense. We could try raising it in this PR or create a separate minor PR for it.
crates/catalog/glue/src/catalog.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug, TypedBuilder)] | ||
| /// Glue Catalog configuration | ||
| pub struct GlueCatalogConfig { |
There was a problem hiding this comment.
Make this crate private.
crates/catalog/glue/src/catalog.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug, TypedBuilder)] |
| //! .load( | ||
| //! "glue", | ||
| //! HashMap::from([( | ||
| //! GLUE_CATALOG_PROP_WAREHOUSE.to_string(), |
There was a problem hiding this comment.
Don't we need uri, name, catalog id?
There was a problem hiding this comment.
Nope, they are actually optional except for catalog name, which is set as glue in .load("glue", xxx)
# Conflicts: # crates/catalog/glue/tests/glue_catalog_test.rs
liurenjie1024
approved these changes
Aug 19, 2025
lliangyu-lin
added a commit
to lliangyu-lin/iceberg-rust
that referenced
this pull request
Aug 21, 2025
## Which issue does this PR close? - Closes [apache#1259](apache#1259). ## What changes are included in this PR? * Added `GlueCatalogBuilder` * Implement `CatalogBuilder` trait for `GlueCatalogBuilder` * Include glue in loader ## Are these changes tested? Added in loader tests and updated glue integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
GlueCatalogBuilderCatalogBuildertrait forGlueCatalogBuilderAre these changes tested?
Added in loader tests and updated glue integration tests