Spark: Log failed catalog load in Spark3Util::catalogAndIdentifier #14183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugo-WB
force-pushed
the
spark-log-failed-catalog-load
branch
from
9a3fb1f to
f653605
Compare
Hugo-WB
force-pushed
the
spark-log-failed-catalog-load
branch
from
f653605 to
fbafc15
Compare
ebyhr
reviewed
Sep 29, 2025
| try { | ||
| return catalogManager.catalog(catalogName); | ||
| } catch (Exception e) { | ||
| LOG.warn("Failed to load catalog", e); |
There was a problem hiding this comment.
How about including the catalog name?
LOG.warn("Failed to load catalog: {}", catalogName, e);There was a problem hiding this comment.
done! thanks for the suggestion 🙏
Thanks to ebyhr for suggestion!
nastra
approved these changes
Oct 1, 2025
ebyhr
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom catalog defined by
catalog-implfails to load, the error is silently caught inSpark3Util::catalogAndIdentifier. This causes confusing downstream errors because it falls back toDEFAULT_CATALOG_NAME(typically HiveCatalog), so users see HiveCatalog errors instead of the actual catalog loading failure.This change adds logging when catalog loading fails to help users quickly identify catalog configuration issues.